[webkit-reviews] review granted: [Bug 35716] Allow static property getters to interact with JSCs caching : [Attachment 49982] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 35716: Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716

Attachment 49982: Patch
https://bugs.webkit.org/attachment.cgi?id=49982&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
 2318	      // Polymorphic self access caching currently only supported when
JITting.
 2319	      ASSERT_NOT_REACHED();
 2320	      // This case of the switch must not be empty, else
(op_get_by_id_self_list == op_get_by_id_chain)!
 2321	      vPC += OPCODE_LENGTH(op_get_by_id_self_list);
 2322	      NEXT_INSTRUCTION();
 2323	  }

 2324	  DEFINE_OPCODE(op_get_by_id_custom_proto_list) {
 2325	      // Polymorphic prototype access caching currently only supported
when JITting.
 2326	      ASSERT_NOT_REACHED();
 2327	      // This case of the switch must not be empty, else
(op_get_by_id_proto_list == op_get_by_id_chain)!
 2328	      vPC += OPCODE_LENGTH(op_get_by_id_proto_list);
 2329	      NEXT_INSTRUCTION();

Probably best to remove the vPC increment in these cases.  In case of error (or
maliciously bad input) it would probably be better to hang than to continue
execution of invalid bytecode.

In 'op_get_by_id_custom_proto' implementation in the interpreter, comments
incorrectly refer to 'op_get_by_id_getter_proto' (from copy and paste,
presumably).  (ditto errors in comments in op_get_by_id_custom_self,
op_get_by_id_custom_chain )

r-, you mix 'C' and 'c' in naming the prgramming language in the changelog.  r+
if you fix that. :-P