[webkit-reviews] review requested: [Bug 26869] Add fill modes for CSS Animations (don't reset state after the animation finishes) : [Attachment 49979] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 19:32:29 PST 2010


Dean Jackson <dino at apple.com> has asked  for review:
Bug 26869: Add fill modes for CSS Animations (don't reset state after the
animation finishes)
https://bugs.webkit.org/show_bug.cgi?id=26869

Attachment 49979: updated patch
https://bugs.webkit.org/attachment.cgi?id=49979&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
Cleaned up the patch a lot. Removal of animations now works. Also,
endAnimation() is unchanged, with other parts of the code guarding against
entering it.

The tests now do not use timeouts (*), which should make the bots happy. They
are slightly less comprehensive as a result, but too bad. Added an extra test
for animation removal.

(*) There is one timeout, but that is a zero delay just to give style a chance
to resolve. The result of the test is not dependent on timing.


More information about the webkit-reviews mailing list