[webkit-reviews] review denied: [Bug 35630] Refactoring: XMLHTTPRequest.open() should have all overloaded implementations : [Attachment 49886] v2; added v8 binding change

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 35630: Refactoring: XMLHTTPRequest.open() should have all overloaded
implementations
https://bugs.webkit.org/show_bug.cgi?id=35630

Attachment 49886: v2; added v8 binding change
https://bugs.webkit.org/attachment.cgi?id=49886&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 No new tests. No functional change.

This is not accurate. This patch changes the behavior of open("GET", url,
undefined) - we used to treat the last argument as false, and now it's true.
This may or may not be desired, depending on what the spec says, and what other
browsers do. It also changes the behavior of open("GET", url, undefined, user,
password), in a way that seems clearly incorrect.

Regardless of whether you decide to keep or drop this change, please add a
regression test that would have caught it.

An existing test xmlhttprequest/basic-auth.html covers undefined and missing
values for user/password, and the patch seems to be fine in this regard.