[webkit-reviews] review denied: [Bug 35691] [Chromium] Adding new platform types for touch events and touch points. : [Attachment 49958] Second-round review fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 15:56:02 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Garret Kelly
(Google) <gdk at chromium.org>'s request for review:
Bug 35691: [Chromium] Adding new platform types for touch events and touch
points.
https://bugs.webkit.org/show_bug.cgi?id=35691

Attachment 49958: Second-round review fixes
https://bugs.webkit.org/attachment.cgi?id=49958&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +class WebTouchPoint {
> +public:
> +    WebTouchPoint()
> +	   : id(0)
> +	   , state(StateUndefined)
> +	   , screenPosition(0, 0)
> +	   , position(0, 0) { }

minor nit: no need to initialize a WebPoint explicitly.  just let
the default constructor do its thing.

otherwise, r=me


More information about the webkit-reviews mailing list