[webkit-reviews] review denied: [Bug 35571] WebSocket bufferedAmount doesn't include framing overhead : [Attachment 49876] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 35571: WebSocket bufferedAmount doesn't include framing overhead
https://bugs.webkit.org/show_bug.cgi?id=35571

Attachment 49876: Patch
https://bugs.webkit.org/attachment.cgi?id=49876&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Isn't 0x00 allowed to be inside of message text? 0xff can never occur in UTF-8,
but 0x00 can be there.

It seems that if bufferedAmount() is going to parse the buffer, then it should
have a state machine, and also ASSERT that it knows about the current frame
type. I don't know how to reasonably implement that, since the buffer won't
necessarily start on frame boundary.

But also, this seems quite slow, perhaps it would be better to store data size
separately (again, it can be a challenge to update properly). Or even to try
and get the spec changed back per implementor feedback.

Do we have a test checking how null characters go over WebSocket?