[webkit-reviews] review denied: [Bug 35583] if font-family lists several generic families, the last one takes precedence : [Attachment 49919] Updated patch with Changelog entry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 10:18:50 PST 2010


Darin Adler <darin at apple.com> has denied Olivier Tilloy <olivier at tilloy.net>'s
request for review:
Bug 35583: if font-family lists several generic families, the last one takes
precedence
https://bugs.webkit.org/show_bug.cgi?id=35583

Attachment 49919: Updated patch with Changelog entry
https://bugs.webkit.org/attachment.cgi?id=49919&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Even if you can't test with DumpRenderTree cross-platform you can do the
following:

    1) Add a DumpRenderTree test that requires per-platform results.

    2) Create a manual test with instructions for how to interpret the results
and put it in WebCore/manual-tests.

    3) Add some new feature to DumpRenderTree to make it possible to test this
across platforms.

As another possibility, is there perhaps some way to detect which family is
used with computed style?

It's not OK to make the change without a test at all, so you need to do at
least one of the things above.


More information about the webkit-reviews mailing list