[webkit-reviews] review denied: [Bug 35590] DOM insertion mutation events should dispatch after a node is attached to the render tree to the document : [Attachment 49910] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 07:57:55 PST 2010


Adam Roben (aroben) <aroben at apple.com> has denied Antoine Quint
<ml at graougraou.com>'s request for review:
Bug 35590: DOM insertion mutation events should dispatch after a node is
attached to the render tree to the document
https://bugs.webkit.org/show_bug.cgi?id=35590

Attachment 49910: Patch
https://bugs.webkit.org/attachment.cgi?id=49910&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
The code changes look good. But I think you should test insertBefore and
replaceChild, too, since you modified those.


More information about the webkit-reviews mailing list