[webkit-reviews] review denied: [Bug 35680] Web Inspector: Popup for Timeline panel will work in a tooltip mode : [Attachment 49904] initial version of patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 3 07:54:55 PST 2010
Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 35680: Web Inspector: Popup for Timeline panel will work in a tooltip mode
https://bugs.webkit.org/show_bug.cgi?id=35680
Attachment 49904: initial version of patch
https://bugs.webkit.org/attachment.cgi?id=49904&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Great job, looks good overall. Couple of nits that need to be fixed prior to
landing. r- for passing panel instance into items.
> + this.sendRequestRecords = {};
> + this.timerRecords = {};
these are private within the file, should remain _*
> +WebInspector.TimelinePanel.showDetailsDelay = 2000;
Should be 1.5s
> +WebInspector.TimelinePanel.hideDetailsDelay = 5000;
Should be infinity (or 10s)
> + get recordStyles()
> + {
_getRecordStyles?
> + var formattedRecord = new
WebInspector.TimelinePanel.FormattedRecord(record, this);
passing panel instance seems to be too much.
> - listRowElement = new
WebInspector.TimelineRecordListRow().element;
ditto.
> + graphRowElement = new
WebInspector.TimelineRecordGraphRow(this, this._itemsGraphsElement,
scheduleRefreshCallback, rowHeight).element;
ditto.
> +WebInspector.TimelinePanel.FormattedRecord.prototype = {
> +_createCell: function(content, styleName)
Here and below - poor indent.
More information about the webkit-reviews
mailing list