[webkit-reviews] review denied: [Bug 35574] Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled : [Attachment 49899] [PATCH] Handle links in the entire WebInspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 05:47:35 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 35574: Web Inspector: Nothing happens on navigation to resource via a link
if resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=35574

Attachment 49899: [PATCH] Handle links in the entire WebInspector
https://bugs.webkit.org/attachment.cgi?id=49899&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>  
> +    if (anchor.hasCustomHandler)
> +	   return;

As we discussed offline, please handle "Profile" and "Resource" panel links
same way.

Also, please move isTransparentRight parameter from calculator to the Graph
representation object.


More information about the webkit-reviews mailing list