[webkit-reviews] review denied: [Bug 35403] Web Inspector: resources panel only shows uncompressed resource size. : [Attachment 49729] [PATCH] Suggested solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 03:18:00 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 35403: Web Inspector: resources panel only shows uncompressed resource
size.
https://bugs.webkit.org/show_bug.cgi?id=35403

Attachment 49729: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=49729&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    get transferSize()
> +    {
> +	   return this.cached ? 0 : (this.responseHeaders["Content-Length"] ||
this.contentLength || 0);
> +    },

What is the difference between Content-Length header and this.contentLength?

> +	   var resourceBytes = this._value(resource);
> +	   if (networkBytes && networkBytes != resourceBytes) {

!==

> +    _networkBytes: function(resource)
> +    {
> +	   return resource.responseHeaders["Content-Length"];

Why not this.contentLength?

> +	   const isTransparentRight = panel && panel.calculator &&
panel.calculator.isTransparentRight;

What is calculator's 'isTransparentRight'? Does not sound like calculator
property?


r- is for "Content-Length" vs contentLength confusion, also for
'isTransparentRight' on calculator.


More information about the webkit-reviews mailing list