[webkit-reviews] review requested: [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") : [Attachment 49884] patch - fixed after mid-air collision, improved robustness, new test case

[bugzilla-daemon at webkit.org]

Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 28293: [Chromium] event.datatransfer.getdata("text/uri-list") treated the
same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Attachment 49884: patch - fixed after mid-air collision, improved robustness,
new test case
https://bugs.webkit.org/attachment.cgi?id=49884&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
The previous r+'d patch had a mid-air collision with another patch that
modified the same code and renamed member variables.

The new patch corrects the resulting conflicts. I also took the opportunity to
apply the result of some discussions on the topic and changed the code so that
it will accept \r\n as line separators in setData (as per the RFC) as well as
just \n (e.g., FireFox also is fine with just \n), in order to add some
robustness.

When creating uri-lists, however, this code will still adhere to the RFC and
use \r\n as line separators.

Consequently I also added a new test case that checks for the case where just
\n is used as line separator.

All in all, with above changes I felt that the new patch should undergo another
review before committing.