[webkit-reviews] review denied: [Bug 35625] Correct base/extent of selection on double-click. : [Attachment 49872] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 35625: Correct base/extent of selection on double-click.
https://bugs.webkit.org/show_bug.cgi?id=35625

Attachment 49872: Patch
https://bugs.webkit.org/attachment.cgi?id=49872&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch has malformed ChangeLog.

+// FIXME: This method shouldn't be necessary. start/end should just be a
function of base/extent
+// instead of separately stored values.

I don't understand. Why? These are completely different values, all visible
through DOM APIs. See for example a test at
<https://bug-4904-attachments.webkit.org/attachment.cgi?id=4806>.

r- for the formal reason of a broken ChangeLog, but I also have strong doubts
about validity of the direction taken here, especially since it;s not explained
at all.