[webkit-reviews] review granted: [Bug 35556] REGRESSION(r51097) - Unable to log in to statefarm.com : [Attachment 49839] Followup that adds whitespace stripping

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 35556: REGRESSION(r51097) - Unable to log in to statefarm.com
https://bugs.webkit.org/show_bug.cgi?id=35556

Attachment 49839: Followup that adds whitespace stripping
https://bugs.webkit.org/attachment.cgi?id=49839&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>      
> -    return equalIgnoringCase(forAttribute, "window") &&
(equalIgnoringCase(eventAttribute, "onload") ||
equalIgnoringCase(eventAttribute, "onload()"));
> +    forAttribute = forAttribute.stripWhiteSpace();
> +    eventAttribute = eventAttribute.stripWhiteSpace();
> +    return equalIgnoringCase(forAttribute.stripWhiteSpace(), "window") &&
(equalIgnoringCase(eventAttribute, "onload") ||
equalIgnoringCase(eventAttribute, "onload()"));

Double whitespace stripping.  Otherwise, this looks fine.  We should really add
functions to do equality ignoring leading/trailing whitespace.

r=me with out the redundancy.