[webkit-reviews] review denied: [Bug 35407] [chromium] add a function to activate the focused node in a WebView : [Attachment 49543] style again

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Evan Stade
<estade at chromium.org>'s request for review:
Bug 35407: [chromium] add a function to activate the focused node in a WebView
https://bugs.webkit.org/show_bug.cgi?id=35407

Attachment 49543: style again
https://bugs.webkit.org/attachment.cgi?id=49543&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebView.h
...
> +    // Activate the currently focused node, if any. If there is no focused
node,
> +    // do nothing.
> +    virtual void activateFocusedNode() = 0;

I think it would be better to provide an accessor for the focusedNode.
Then add a method on WebNode called simulateClick.  It is better to
provide the basic building blocks in the API, so that we can more easily
do other things in the future.

My only question is whether or not we need to pass a WebInputEvent to
that simulateClick method.  This could matter for the popup blocker
since it will need to know if there was a user gesture.  Have you
tested what happens if the 'click' event handler tries to open up a
popup window?