[webkit-reviews] review granted: [Bug 35576] WebKit should tell plug-in instances when private browsing state changes : [Attachment 49832] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 2 13:01:15 PST 2010


Darin Adler <darin at apple.com> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 35576: WebKit should tell plug-in instances when private browsing state
changes
https://bugs.webkit.org/show_bug.cgi?id=35576

Attachment 49832: Patch v2
https://bugs.webkit.org/attachment.cgi?id=49832&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

I would add a comment to the Page::privateBrowsingStateChanged function
explaining that the function uses local variables so it can run to completion
even if the entire Page is destroyed.


More information about the webkit-reviews mailing list