[webkit-reviews] review granted: [Bug 35566] WebKit needs ability to dispatch mousewheel events. : [Attachment 49790] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 2 02:17:11 PST 2010


Maciej Stachowiak <mjs at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 35566: WebKit needs ability to dispatch mousewheel events.
https://bugs.webkit.org/show_bug.cgi?id=35566

Attachment 49790: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49790&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Suggestions from IRC: 
- instead of the long comments explaining the difference between
m_wheelDeltaX/Y and m_deltaX/Y, I would suggest giving them names that make the
difference more clear
- m_wheelDeltaX/Y are exposed by that name in the API, perhaps the others could
be m_rawDeltaX/Y or m_pixelDeltaX/Y

r=me with that change.


More information about the webkit-reviews mailing list