[webkit-reviews] review denied: [Bug 35565] Google Analytics triggers "blocked plugin" UI : [Attachment 49784] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 2 00:27:35 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 35565: Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Attachment 49784: Patch
https://bugs.webkit.org/attachment.cgi?id=49784&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Thanks for working on this! Just some minor issues:
> +++ b/WebCore/loader/FrameLoader.cpp
> + const bool allowed = m_client->allowPlugins(settings &&
settings->arePluginsEnabled());
nit: gratuitous const :)
> +++ b/WebCore/loader/FrameLoader.h
> @@ -82,6 +82,11 @@ class Widget;
> struct FrameLoadRequest;
> struct WindowFeatures;
>
> +enum ReasonForCallingAllowPlugins {
> + AboutToInstantiatePlugin,
> + NotAboutToInstantiatePlugin
> +};
^^^ maybe this should go in FrameLoaderTypes.h?
> +++ b/WebCore/loader/MainResourceLoader.cpp
...
> + if (!m_frame->loader()->allowPlugins(NowAboutToInstantiatePlugin))
NowAboutToInstantiatePlugin -> AboutToInstantiatePlugin, right?
> +++ b/WebKit/chromium/public/WebFrameClient.h
> + // Notifies the client that the frame would have instanitated a plug-in
if plug-ins were enabled.
instanitated -> instantiated
More information about the webkit-reviews
mailing list