[webkit-reviews] review granted: [Bug 35551] Hardcoding of /usr/bin/gcc in perl build scripts : [Attachment 49760] Patch to change /usr/bin/gcc to $ENV{CC} in perl build scripts.

[bugzilla-daemon at webkit.org]

Fred Ollinger <Fred_Ollinger at seektech.com> has granted	review:
Bug 35551: Hardcoding of /usr/bin/gcc in perl build scripts
https://bugs.webkit.org/show_bug.cgi?id=35551

Attachment 49760: Patch to change /usr/bin/gcc to $ENV{CC} in perl build
scripts.
https://bugs.webkit.org/attachment.cgi?id=49760&action=review

------- Additional Comments from Fred Ollinger <Fred_Ollinger at seektech.com>
Recently when trying to cross the nightly build: r55354, I noticed that several
Perl scripts hardcoded the path to /usr/bin/gcc. Obviously, this completely
breaks a cross compile as a cross compiler should not be installed in
/usr/bin/gcc; that's where the native compiler is NOT the cross compiler. 

There are four perl build scripts that hard code /usr/bin/gcc as the default
compiler. This is true even if one has chosen to cross-compile. This should
effectively break cross-compiling as there is no way to tell ./configure that
gcc is located in an alternate location. This bug will also break use of
another compiler other than gcc. It will also break using a different version
of gcc if it is not installed in the default location of /usr/bin/gcc.

To fix this, I first isolated the areas where /usr/bin/gcc was called from
Perl. Then I changed references from "/usr/bin/gcc" to $ENV{CC} which will
allow a user to use any version of gcc that they wish. Patch is attached.


1. bindings/scripts/CodeGeneratorObjC.pm   

2. bindings/scripts/IDLParser.pm	

3. css/make-css-file-arrays.pl

4. dom/make_names.pl

Fred Ollinger
Embedded Software Engineer
Seektech, Incorporated
http://www.seektechinc.com/
fred_ollinger at seektech.com