[webkit-reviews] review granted: [Bug 35514] AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver : [Attachment 49709] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 35514: AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

Attachment 49709: patch
https://bugs.webkit.org/attachment.cgi?id=49709&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems to me that this idiom:

    if (needsToUpdateChildren())
	clearChildren();

    if (!hasChildren())
	addChildren();

Should be in a helper function. It's not good to repeat it all those different
places.

Can we make the needsToUpdateChildren protected instead of public?