[webkit-reviews] review denied: [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts. : [Attachment 49727] Simple fix for bug 35530.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Lyon Chen
<lyon.chen at torchmobile.com>'s request for review:
Bug 35530: Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro
conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Attachment 49727: Simple fix for bug 35530.
https://bugs.webkit.org/attachment.cgi?id=49727&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
A change like this needs a comment. Having these #undef at the top of the file
with no comment is not good.

The extra blank line before the class definition is not wanted.

A better change would be to change these identifiers. There's no reason to use
all capitals for these. While the #undef will work it's probably not a major
project to simply change these to use normal mixed case as per the WebKit
coding guidelines.

review- because there needs to be a comment