[webkit-reviews] review denied: [Bug 18819] WebKit misplaces cursor on option/control-pageup/pagedown : [Attachment 49710] v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 18819: WebKit misplaces cursor on option/control-pageup/pagedown
https://bugs.webkit.org/show_bug.cgi?id=18819

Attachment 49710: v1
https://bugs.webkit.org/attachment.cgi?id=49710&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO ||
renderer->isTextArea()))
> +    if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO ||
renderer->isTextArea() || focusedNode->isContentEditable()))

There is no comment here explaining why this code change is correct.

And, further, I think this code change is wrong. If we want the editing meaning
of page-down or option-page-down to win out over the scrolling meaning of the
same equivalent, that may be fine, but we should *not* do it by returning 0
from verticalScrollDistance when there is a editable node focused. That's too
low a level for this sort of policy decision. I don't immediately know which
level should make this tradeoff, but this is slightly too low.