[webkit-reviews] review requested: [Bug 35347] Convert the zoom mode into a proper enum : [Attachment 49746] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 13:07:27 PST 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 35347: Convert the zoom mode into a proper enum
https://bugs.webkit.org/show_bug.cgi?id=35347

Attachment 49746: Patch
https://bugs.webkit.org/attachment.cgi?id=49746&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Substituted symbols __ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE and
__ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for
__ZN7WebCore5Frame13setZoomFactorEfb and
__ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.

Set role of ZoomMode.h to private in Xcode project.

Resolved compiler error in [-WebView _setZoomMultiplier:isTextOnly] caused by
using the old prototype for Frame::setZoomFactor (which took a boolean type for
the second argument). Instead, the second argument is now an enum value.


More information about the webkit-reviews mailing list