[webkit-reviews] review granted: [Bug 35537] put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written. : [Attachment 49737] The patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 35537: put_by_id does will incorrectly cache writes where a specific value
exists, where at the point of caching the same value is being written.
https://bugs.webkit.org/show_bug.cgi?id=35537

Attachment 49737: The patch
https://bugs.webkit.org/attachment.cgi?id=49737&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +	   //  (1) There is an existing specific value set, and we're
overwriting with *the same value*.
> +	   //	    * Do nothing – no need to despecify, but that means we
can't cache (a cached
r+ but get rid of yer funny foreign characters :p

--Oliver