[webkit-reviews] review denied: [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame : [Attachment 49676] patch v2.6

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 35210: [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

Attachment 49676: patch v2.6
https://bugs.webkit.org/attachment.cgi?id=49676&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 20 #include "config.h"
 21 
 22 #include "webkitgeolocationpolicydecision.h"
 23 
 24 #include "webkitprivate.h"
 25 
 26 #include "Geolocation.h"

These spaces are wrong. You should have this, instead:

 #include "config.h"
 #include "webkitgeolocationpolicydecision.h"

 #include "Geolocation.h"
 #include "webkitprivate.h"

 65 
 66 
 67	priv->frame = frame;

Too many empty lines here.

 78  * Since: 1.1.22

These should be 1.1.23, now =)

Except for these, I think this should be good to go.