[webkit-reviews] review granted: [Bug 35265] new-run-webkit-tests --platform=mac-leopard diffs are backwards : [Attachment 49664] posting a revised patch since Eric is OOO

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 35265: new-run-webkit-tests --platform=mac-leopard diffs are backwards
https://bugs.webkit.org/show_bug.cgi?id=35265

Attachment 49664: posting a revised patch since Eric is OOO
https://bugs.webkit.org/attachment.cgi?id=49664&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py
b/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py
> +    def diff_text(self, expected_text, actual_text,
> +		     expected_filename, actual_filename):

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
b/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
> +    def diff_text(self, expected_text, actual_text,
> +	       expected_filename, actual_filename):

fwiw, this indent doesn't align with the (. Note that there are many examples
even within this patch of the alignment happening.