[webkit-reviews] review denied: [Bug 35526] [V8] V8 should be notified of context disposals : [Attachment 49721] Notify V8 of context disposals to allow it to clean up when idle.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 08:07:40 PST 2010


Adam Barth <abarth at webkit.org> has denied Mads Ager <ager at chromium.org>'s
request for review:
Bug 35526: [V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526

Attachment 49721: Notify V8 of context disposals to allow it to clean up when
idle.
https://bugs.webkit.org/attachment.cgi?id=49721&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please put V8GCForContextDispose in its own file (one class per file).	Also,
please update the DEPS file above so we can keep building upstream.

How much power does this idle spin eat?

Other than that, looks fine.


More information about the webkit-reviews mailing list