[webkit-reviews] review granted: [Bug 35435] Merge ValidityState-stepMismatch-{number, range, unsupported}.html and input-step-{number, range, unsupported}.html to other tests : [Attachment 49594] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 00:21:30 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 35435: Merge ValidityState-stepMismatch-{number,range,unsupported}.html and
input-step-{number,range,unsupported}.html to other tests
https://bugs.webkit.org/show_bug.cgi?id=35435

Attachment 49594: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49594&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, but could you check if the combined test is fast enough in debug
mode? Sometimes big tests introduce flakiness...

Also, could you put the bug number where Darin commented in this bug? It would
make the motivation of this change clearer.


More information about the webkit-reviews mailing list