[webkit-reviews] review granted: [Bug 41439] BogusCommentState should come in from the cold : [Attachment 60174] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 30 17:49:44 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41439: BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439
Attachment 60174: Patch
https://bugs.webkit.org/attachment.cgi?id=60174&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/html5lib/webkit-resumer-expected.txt:159
+ resources/webkit01.dat:
Geez, we still need to fix this output.
WebCore/html/HTMLTokenizer.cpp:1078
+ else if (cc == InputStreamPreprocessor::endOfFileMarker)
I should have written these as isEndOfFileMarker(cc)
Why do we need ContinueBogusCommentState? Why not just check m_token->type()
== Comment?
More information about the webkit-reviews
mailing list