[webkit-reviews] review granted: [Bug 41320] Add adoptPtr and leakPtr functions for OwnPtr and PassOwnPtr : [Attachment 60159] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 41320: Add adoptPtr and leakPtr functions for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=41320

Attachment 60159: Patch
https://bugs.webkit.org/attachment.cgi?id=60159&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm slightly nervous about the CrossOriginPreflightResultCache part because I
don't understand it fully.

JavaScriptCore/wtf/PassOwnPtr.h:79
 +	    PassOwnPtr(PtrType ptr) : m_ptr(ptr) { }
Explicit?  I guess it wasn't explicit before....

JavaScriptCore/wtf/PassOwnPtr.h:85
 +	    explicit PassOwnPtr(PtrType ptr) : m_ptr(ptr) { }
How does this differ from the above?

WebCore/css/CSSSegmentedFontFace.cpp:113
 +	    if (const SimpleFontData* faceFontData =
m_fontFaces[i]->getFontData(fontDescription, syntheticBold, syntheticItalic)) {

Seems slightly unrelated, but yay for removing static_cast

WebCore/loader/CrossOriginPreflightResultCache.cpp:155
 +	    delete addResult.first->second;
Is this a real leak that you're fixing at the same time?  Might be better to do
in a separate patch.  I don't understand this part well enough to know if it's
right.