[webkit-reviews] review granted: [Bug 41422] Add assertion, off by default, for when you forget to do adoptRef : [Attachment 60151] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 30 14:22:56 PDT 2010
Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 41422: Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422
Attachment 60151: Patch
https://bugs.webkit.org/attachment.cgi?id=60151&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good. Not sure why I went off to template land before for this patch.
JavaScriptCore/wtf/PassRefPtr.h:32
+ inline void adopted(const void*)
One line?
JavaScriptCore/wtf/RefCounted.h:70
+ ASSERT(m_deletionHasBegun);
This means we'll need to delete via deref(), right?
More information about the webkit-reviews
mailing list