[webkit-reviews] review granted: [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup : [Attachment 60124] Patch V2 with fixing style warnings, add a plugin test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 14:09:18 PDT 2010


Adam Barth <abarth at webkit.org> has granted Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 41292: [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in
browser, if the call is initiated by user, allow the popup
https://bugs.webkit.org/show_bug.cgi?id=41292

Attachment 60124: Patch V2 with fixing style warnings, add a plugin test
https://bugs.webkit.org/attachment.cgi?id=60124&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Nice test.  Thanks.

WebCore/bindings/v8/NPV8Object.cpp:282
 +	// Initialize UserGestureIndicator to right value.
This comment is redundant and probably should be removed.


More information about the webkit-reviews mailing list