[webkit-reviews] review granted: [Bug 41385] [chromium] Make the user script API static. : [Attachment 60075] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 41385: [chromium] Make the user script API static.
https://bugs.webkit.org/show_bug.cgi?id=41385

Attachment 60075: Patch
https://bugs.webkit.org/attachment.cgi?id=60075&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebViewImpl.cpp:1976
 +	Vector<String>* patterns = new Vector<String>;
nit: use OwnPtr here?

WebKit/chromium/src/WebViewImpl.cpp:1988
 +	Vector<String>* patterns = new Vector<String>;
nit: use OwnPtr here?

i realize that your code is correct, but if someone ever added an early
return it would suddenly start leaking memory.	plus, i was only able
to convince myself that your code was safe by checking the signature
of addUser{Script,StyleSheet}ToWorld to see that it takes a PassOwnPtr
parameter.

r=me otherwise