[webkit-reviews] review granted: [Bug 41416] Add WebProcessProxy::send : [Attachment 60127] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 41416: Add WebProcessProxy::send
https://bugs.webkit.org/show_bug.cgi?id=41416

Attachment 60127: Patch
https://bugs.webkit.org/attachment.cgi?id=60127&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    CoreIPC::Connection* connection() const
> +    { 
> +	   ASSERT(m_connection);
> +	   
> +	   return m_connection.get(); 
> +    }

I don't see any callers of this new function.

> +template<typename E, typename T>
> +bool WebProcessProxy::send(E messageID, uint64_t destinationID, const T&
arguments)
> +{
> +    std::auto_ptr<CoreIPC::ArgumentEncoder> argumentEncoder(new
CoreIPC::ArgumentEncoder(destinationID));
> +    argumentEncoder->encode(arguments);
> +
> +    return sendMessage(CoreIPC::MessageID(messageID), argumentEncoder);
> +}

Why are you using auto_ptr instead of OwnPtr?

r=me