[webkit-reviews] review granted: [Bug 41397] HTMLTokenizer should use fewer macros : [Attachment 60102] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41397: HTMLTokenizer should use fewer macros
https://bugs.webkit.org/show_bug.cgi?id=41397

Attachment 60102: Patch
https://bugs.webkit.org/attachment.cgi?id=60102&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I like this.  It's a bit subtle that we now always have to call "return emit*"
and never just "emit*".  The macros were slightly nice for making sure folks
didn't hit that error.

You might try searching for "  emit" just to make sure we didn't miss one.

"bufferCurrentToken" makes little sense. :)  It's an emit-helper, it doesn't do
any buffering.	bufferCharacter on the other hand is a great name!

bufferEndOfFile also makes no sense.  it's just called by emitEndOfFile and can
just be inlined.