[webkit-reviews] review requested: [Bug 38648] Ensure DRT loads GAIL (Gtk+ module), for a11y tests : [Attachment 60098] Patch to fix this issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 30 01:38:05 PDT 2010
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 38648: Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Attachment 60098: Patch to fix this issue
https://bugs.webkit.org/attachment.cgi?id=60098&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
It looks like this patch has been rolled out because it seems it broke some
tests:
https://bugs.webkit.org/show_bug.cgi?id=41346
http://trac.webkit.org/changeset/62110
I had no idea what could went wrong there apart that there was a missing ";" in
the previous patch (I didn't realize of this since it worked in my local
environment), so I'm now attaching a new patch with that simple modification to
see if it helps, but no many hopes put down on there...
Btw, any tip on this would be welcome, since this bug is blocking other a11y
fixes and if I can't reproduce the problem locally I'm not sure I'll be able to
find the proper solution for that.
Thanks
More information about the webkit-reviews
mailing list