[webkit-reviews] review granted: [Bug 41327] WebSocket: Malformed handshake headers in a worker due to rand_s failing : [Attachment 60085] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 41327: WebSocket: Malformed handshake headers in a worker due to rand_s
failing
https://bugs.webkit.org/show_bug.cgi?id=41327

Attachment 60085: Patch
https://bugs.webkit.org/attachment.cgi?id=60085&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, but a stripWhiteSpace() call on the result would have looked less
alarming (even if we're losing a tiny bit of randomness that way).

>    DEFINE_STATIC_LOCAL(String, randomChars,
(randomCharacterInSecWebSocketKey));
>     DEFINE_STATIC_LOCAL(String, spaceChar, (" "));

I'd have added String::insert(UChar) for this. But it's not new with this
patch.