[webkit-reviews] review denied: [Bug 40515] Add a low-level platform abstraction for copy-and-paste and drag-and-drop data. : [Attachment 58549] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 40515: Add a low-level platform abstraction for copy-and-paste and
drag-and-drop data.
https://bugs.webkit.org/show_bug.cgi?id=40515

Attachment 58549: Patch
https://bugs.webkit.org/attachment.cgi?id=58549&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +class ClipboardData : public RefCounted<ClipboardData> {

This seems fine, but I'm not sure why it's an abstract base class. Generally
speaking the platform directory does not use runtime factories that vend
objects of abstract base classes. I have seen other libraries that use this
approach, but it has runtime costs that we prefer not to pay in WebKit.

The interface here looks generally OK in terms of what the functions are and
the argument types, but the basic approach does not seem right.

An example of how we do this without virtual functions is in the FileChooser.h
source file. Not sure that needs to be a reference-counted object, but
otherwise it's a reasonable example. DragData.h is another example, although a
particularly messy one.