[webkit-reviews] review granted: [Bug 40398] Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView : [Attachment 59970] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 10:26:38 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 40398: Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for
texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398

Attachment 59970: Revised patch
https://bugs.webkit.org/attachment.cgi?id=59970&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me (pair programming FTW!), except:

WebCore/html/canvas/WebGLRenderingContext.cpp:3567
 +	    return false;
Need to synthesize an error here.


More information about the webkit-reviews mailing list