[webkit-reviews] review requested: [Bug 39997] [Gtk] Make sure DRT return the right AXTitle for controls : [Attachment 60026] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 09:15:28 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 39997: [Gtk] Make sure DRT return the right AXTitle for controls
https://bugs.webkit.org/show_bug.cgi?id=39997

Attachment 60026: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=60026&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 57570 [details] [details])
> > Mario thinks this won't apply anymore to trunk, so removing cq+
> 
> Yeah, I need to recheck this, and maybe come with an up-to-date patch since
> it's possible the modifications in AccessibilityobjectWrapperAtk.cpp are no
> longer needed after fixing bug 36128.

Indeed, the previous patch wouldn't apply so this new one makes a lot of sense
:-). In the other hand, I was wrong in my guessing and no code can be removed
just because of bug 36128, so the new patch is basically the same one than
before, but properly applying against latest trunk.


More information about the webkit-reviews mailing list