[webkit-reviews] review requested: [Bug 38256] [GTK] Random failure on 'testdownload' unit test : [Attachment 60024] Make sure the set_filename function is called after handling the 'download-requested' signal for the asynchronous test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 38256: [GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Attachment 60024: Make sure the set_filename function is called after handling
the 'download-requested' signal for the asynchronous test
https://bugs.webkit.org/attachment.cgi?id=60024&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #19)
> (In reply to comment #18)
> > > 
> > > Mmm, do you really need to dup the string?
> > 
> > As the string is gonna be used in a function called "on idle", I'd rather
do it this way and then free the string there. I think it's safer.
> 
> AFAICT the string survives across the whole test, so whether it's used in an
idle or not is irrelevant here.

Ok, you convinced me :-)

Here you have the new patch then