[webkit-reviews] review canceled: [Bug 39019] [Qt] Combobox doesn't close when scrolling in graphicsbased mode : [Attachment 60003] Patch v2

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has canceled  review:
Bug 39019: [Qt] Combobox doesn't close when scrolling in graphicsbased mode
https://bugs.webkit.org/show_bug.cgi?id=39019

Attachment 60003: Patch v2
https://bugs.webkit.org/attachment.cgi?id=60003&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
I think that this patch should not go in.

After having a look I saw that QtAbstractWebPopup is not exposed in the API,
and this patch would change the containment of a QGraphicsWebView inside a
scene like SecondLife probably needed.

To use a QWidget combo box popup we would need to know if the developer wants
to use QGraphicsWebView for its advantages (like accelerated compositing,
tiling) or because he wants it inside a QGraphicsScene. Until we have a flag or
a class that separate these two cases I think we should keep this behavior for
popups.

I have another fix (mostly in Qt) for this bug and I'll push it when possible.