[webkit-reviews] review requested: [Bug 25528] [Gtk] Text attributes not exposed : [Attachment 60022] webkit_accessible_text_get_default_attributes and webkit_accessible_text_get_run_attributes implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 07:54:53 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25528: [Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528

Attachment 60022: webkit_accessible_text_get_default_attributes and
webkit_accessible_text_get_run_attributes implementation
https://bugs.webkit.org/attachment.cgi?id=60022&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #18)
> (From update of attachment 58670 [details])
> Looks good, but this still uses g_timeout_add in the test. Can you change it
to an idle and we get this in? Sorry for the trouble.

Thanks for noticing. After all it's not just a matter of replacing the timeout
for and idle_add but also about having a patch that compiles against current
status of trunk :-)

Created a new patch against trunk then and tested, so here you have it.


More information about the webkit-reviews mailing list