[webkit-reviews] review requested: [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag : [Attachment 60015] viewport-patch-for-eflwebkit-13

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 05:53:12 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 40278: [EFL] EFLWebKit doesn't support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=40278

Attachment 60015: viewport-patch-for-eflwebkit-13
https://bugs.webkit.org/attachment.cgi?id=60015&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Hello Keneeth,

I told that you rejected this patch. Because, there are mixing zoom with scale.


   priv->settings.zoom_range.min_scale = ZOOM_MIN;
   priv->settings.zoom_range.max_scale = ZOOM_MAX;

However, there is no scale seprated from zooming in webkit-efl. As far as I
know, webkit-efl can scale based on zoom.
Thus, this patch implements functionality of viewport meta tag using zoom.

In order to avoid this patch can make a confusion, I add comments for this
issue as below,

   // Since there's no scale separated from zooming in webkit-efl, this
functionality of
   // viewport meta tag is implemented using zoom.
   priv->settings.zoom_range.min_scale = ZOOM_MIN;
   priv->settings.zoom_range.max_scale = ZOOM_MAX;

If webkit-efl separate scale from zoom, I will also modify this patch based on
the change.


Hello barbieri and lucas,

I would like to know your opinions as well.


Thank you,
Gyuyoung Kim


More information about the webkit-reviews mailing list