[webkit-reviews] review requested: [Bug 38256] [GTK] Random failure on 'testdownload' unit test : [Attachment 60009] Make sure the set_filename function is called after handling the 'download-requested' signal for the asynchronous test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 38256: [GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Attachment 60009: Make sure the set_filename function is called after handling
the 'download-requested' signal for the asynchronous test
https://bugs.webkit.org/attachment.cgi?id=60009&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #17)
> [...]
> As commented, it would be nice to add here the explanation in comment #15,
since you already wrote it.

Done, sorry.

> >+		g_idle_add((GSourceFunc)set_filename,
g_strdup(temporaryFilename));
> 
> Mmm, do you really need to dup the string?

As the string is gonna be used in a function called "on idle", I'd rather do it
this way and then free the string there. I think it's safer.

> [...]
> >+	GCallback dr_cb = NULL;
> 
> downloadRequestCallback? or downloadRequestCB? or something not 'dr_cb' :D

Sure! Done.

Attached new patch addressing these issues