[webkit-reviews] review denied: [Bug 40781] Web Inspector: show actual breakpoint position in UI. : [Attachment 59905] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 03:05:33 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 40781: Web Inspector: show actual breakpoint position in UI.
https://bugs.webkit.org/show_bug.cgi?id=40781

Attachment 59905: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=59905&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorController.cpp:1758
 +	m_breakpointsMapping.set(breakpointId, actualLineNumber);
I still do not understand why you need this mapping. Again, name is confusing
in either case.


More information about the webkit-reviews mailing list