[webkit-reviews] review denied: [Bug 41337] Teach HTML5TreeBuilder how to merge attributes from extra html/body elements : [Attachment 59994] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 29 00:00:26 PDT 2010
Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41337: Teach HTML5TreeBuilder how to merge attributes from extra html/body
elements
https://bugs.webkit.org/show_bug.cgi?id=41337
Attachment 59994: Patch
https://bugs.webkit.org/attachment.cgi?id=59994&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTMLTreeBuilder.h:142
+ m_htmlElement =
static_cast<HTMLHtmlElement*>(element.get());
Let's take out these static casts.
WebCore/html/HTMLTreeBuilder.h:212
+ // keeps them alive. They are never popped from the stack.
Can you ASSERT this during pop?
More information about the webkit-reviews
mailing list