[webkit-reviews] review granted: [Bug 41297] [V8] Catch toString() exceptions in all DB-related code in V8 bindings : [Attachment 59991] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 41297: [V8] Catch toString() exceptions in all DB-related code in V8
bindings
https://bugs.webkit.org/show_bug.cgi?id=41297

Attachment 59991: patch
https://bugs.webkit.org/attachment.cgi?id=59991&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good.

WebCore/bindings/v8/custom/V8BindingMacros.h:35
 +	    var = value;		      \
It's usually a good idea to put parenthesis around (value).  Otherwise you
might get strange order-of-operations issues.

WebCore/bindings/v8/custom/V8BindingMacros.h:44
 +	    v8::Handle<v8::String> v8String = value->ToString();	      
\
It's usually a good idea to put parenthesis around (value).  Otherwise you
might get strange order-of-operations issues.