[webkit-reviews] review granted: [Bug 5861] feConvolveMatrix filter is not implemented : [Attachment 59890] Updated patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 5861: feConvolveMatrix filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5861

Attachment 59890: Updated patch
https://bugs.webkit.org/attachment.cgi?id=59890&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
WebCore/svg/SVGFEConvolveMatrixElement.cpp:117
 +	for (int i = 0; i < numberOfItems; i++)
I'd prefer ++i here, but hey :-)

WebCore/svg/SVGFEConvolveMatrixElement.cpp:145
 +	    for (int i = 0; i < numberOfItems; i++)
Ditto.

WebCore/svg/SVGFEConvolveMatrixElement.cpp:148
 +		divisorValue = 1.0f;
= 1; No .0f postfixes (new style rule).

Please fix before landing! r=me.