[webkit-reviews] review granted: [Bug 40484] Add beforeScript (or equivalent) event to fire on inline scripts and inline stylesheets : [Attachment 59984] Split BeforeProcess into BeforeProcessScript and BeforeProcessStyle

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 40484: Add beforeScript (or equivalent) event to fire on inline scripts and
inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=40484

Attachment 59984: Split BeforeProcess into BeforeProcessScript and
BeforeProcessStyle
https://bugs.webkit.org/attachment.cgi?id=59984&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 62085)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,67 @@
> +2010-06-28  Brady Eidson  <beidson at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   More progress on https://bugs.webkit.org/show_bug.cgi?id=40484
> +
> +	   It has become apparent that beforeprocessscript and
beforeprocessstyle need to be separate,
> +	   and also that onbeforeprocessscript should not exist, while
onbeforeprocessstyle should.
> +

Please add more information here.

> +    void initBeforeProcessScriptEvent(const AtomicString& type, bool
canBubble, bool cancelable)
> +    {
> +	   initEvent(type, canBubble, cancelable);
> +    }

Should this take a text argument as well? (Same question for the style event as
well.

Do you plan on adding BeforeProcessEventConstructor and
BeforeProcessStyleEventConstructor to DOMWindow.idl in a follow up patch?

Seems fine as a stepping stone. r=me.