[webkit-reviews] review requested: [Bug 40398] Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView : [Attachment 59964] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 40398: Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for
texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398

Attachment 59964: Patch
https://bugs.webkit.org/attachment.cgi?id=59964&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:

Added support for UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixel
store parameters to texImage2D and texSubImage2D entry points taking
ArrayBufferView. More cleanly separated the unpacking and packing phases of
user-supplied pixel data in GraphicsContext3D, and added support for unpack
alignment. Fixed bug in handling of unpackAlignment in
GraphicsContext3D::flipVertically. Necessarily added validation of the amount
of data passed to texImage2D and texSubImage2D. Modified
fast/canvas/webgl/tex-image-with-format-and-type.html to include premultiplied
alpha tests for relevant source formats; added new test which exercises all
combinations of UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL, and
UNPACK_ALIGNMENT pixel store parameters.

Note to reviewers:

This patch is large, but the individual code changes are small and easily
reviewable, and it is not possible to break it down into any smaller set of
patches which are individually testable. The test cases and their boilerplate
output comprise more than half of the patch. The test cases are as exhaustive
as possible and caught a couple of implementation errors.